Looks good. /Erik
On 2018-05-03 04:33, Severin Gehwolf wrote:
Hi, Could I please get a review of this change for JDK 8u? We are seing build failures due to unresolved symbols when building libfontmanager.so. The build flag to trigger this is to configure with: --with-extra-ldflags="-Wl,-z,defs" Attempting a build of JDK 8 with this fails. This has been fixed in JDK 11 and hasn't shown any issues so far. Due to the change in the build system the JDK 11 patch does not apply cleanly after path unshuffeling (different context it seems). Hence, asking here for a review before asking for JDK 8 backport approval. Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.jdk8/ Review thread for JDK 11: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021575.html Thanks, Severin
