Hi Eric, thanks for that excellent suggestion. I already thought there should be some means to do that but was not aware of how that could be accomplished. I updated the webrev in place.
Thanks Christoph > -----Original Message----- > From: Erik Joelsson [mailto:erik.joels...@oracle.com] > Sent: Freitag, 4. Mai 2018 17:45 > To: Langer, Christoph <christoph.lan...@sap.com>; awt- > d...@openjdk.java.net > Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net > Subject: Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT > Input Method Framework (IMF) > > Hello, > > It looks like what you are trying to achieve is to override > awt_InputMethod.c with an OS specific version of that file. We have a > construct for this in SetupNativeCompilation that should handle it > automatically, if you just list the source dirs in priority order. I > would suggest leveraging this by making this change instead: > > First in the list of LIBAWT_XAWT_DIRS (line 272), prepend a line like this: > > $(wildcard > $(TOPDIR)/src/java.desktop/$(OPENJDK_TARGET_OS)/native/libawt_xawt) > \ > > /Erik > > > On 2018-05-04 07:07, Langer, Christoph wrote: > > Hi, > > > > please help reviewing the contribution of the support for the AIX Input > Method Editor (IME) in AWT's Input Method Framework. > > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8201429.1/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8201429 > > > > I took Ichiroh's initial proposal [1] and tried to integrate it better with > existing code. I have split > src/java.desktop/unix/classes/sun/awt/X11InputMethod.java into > > a) a base class containing the common code: > src/java.desktop/unix/classes/sun/awt/X11InputMethodBase.java > > b) a specific class for the common Linux/Unixes: > src/java.desktop/unix/classes/sun/awt/X11InputMethod.java and > > c) a specific class for AIX: > src/java.desktop/aix/classes/sun/awt/X11InputMethod.java > > > > The AIX specific additions to the native code of > src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c were so > much that I decided to add a specific implementation file for AIX: > src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod_aix.c. The > changes to the former file are some cleanups. > > > > I'm still in the process of testing the changes - but maybe you can run > further tests, especially on non-AIX unixes to make sure we didn't break > something. > > > > Thanks & Best regards > > Christoph > > > > [1]: http://mail.openjdk.java.net/pipermail/awt-dev/2018- > April/013869.html > >
