Thanks Erik -
OK, got those indent and line breaks added, updated webrev in the same
location.
Quite right, it will accept the devkit location with being told its
specific toolchain version.
Thanks for the feeback!
Kevin
On 18/05/2018 22:14, Erik Joelsson wrote:
Hello,
In toolchain_windows.m4, line 296 needs indentation. Also you skipped
line 327-332 which were broken up in the jdk 9 change.
Can't see anything functionally bad, only style issues.
I don't think you need to specify --with-toolchain-version=2013 when
using the devkit, it should contain the necessary information for
configure to pick it up automatically.
/Erik
On 2018-05-18 13:42, Kevin Walls wrote:
Hi,
I'd like to get a review of a backport from 9 to 8u:
8078437: Enable use of devkits for Windows.
JBS: https://bugs.openjdk.java.net/browse/JDK-8078437
9 changeset:
URL: http://hg.openjdk.java.net/jdk9/dev/rev/bc02cff96b92
9 review thread:
http://mail.openjdk.java.net/pipermail/build-dev/2015-April/014870.html
8u webrev: http://cr.openjdk.java.net/~kevinw/8078437/webrev.00/
common/autoconf/toolchain_windows.m4 ...this one had some manual
work, but some of that was just re-indenting.
common/autoconf/toolchain.m4 change didn't import but the line split
in the if statement looks cosmetic anyway. I copied it as I'm here.
Other files import OK, plus regenerating the generated files.
With this change, the regular build still works as before, plus we
can do:
$ bash ./configure --with-toolchain-version=2013
--with-devkit=/devkitdir
..and e.g. make images uses that compiler.
(that does also need the hotspot change 8203349, but 2013 is the
devkit bundle I have to hand)
Thanks!
Kevin
