On 2018-05-25 01:21, Magnus Ihse Bursie wrote:
On 2018-05-16 16:18, Magnus Ihse Bursie wrote:
16 maj 2018 kl. 01:39 skrev Erik Joelsson<erik.joels...@oracle.com>:
Hello,
In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice.
Oops, will fix.
Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we should
be moving them to one place? Regardless, I think we need an INCLUDE in the
SetupJavaCompilation so that we only build the tool we need. There is currently
no other tools in make/src/classes, but that directory is inviting for others.
I think we should move all tools to a common place. The current solution is
more an effect of how things ended up due to the old multi-repo design.
So I though: let's start doing things right, and put this one in a common build
tool directory, and then we can move the rest there in a follow up.
But if you think that is confusing (I could really agree) we can skip doing
that now. If so, I'll just move this to some jfr_build_tools_classes dir
instead.
I never got a response to this, so I took this as an acceptance and
went ahead and pushed it. :-)
I opened https://bugs.openjdk.java.net/browse/JDK-8203821 as an
enhancement to track the need to deal with the entire java-build-tools
thing properly.
Hope this was an acceptable solution to you.
I was expecting a new version of the review where you addressed the need
for INCLUDE in SetupJavaCompilation. What you pushed works for now
because this is the only tool in that source tree, but will not work if
you add another tool. As I see it, we need to either:
1. Build all the tools in one go, into a common output dir like
"tools_classes"
2. Build each tool separately, carefully only including the relevant
files, preferably into separate output dirs, but sharing here is
possible, though ugly IMO.
/Erik
/Magnus
/Magnus
/Erik
On 2018-05-15 16:14, Magnus Ihse Bursie wrote:
Cleanups of the build system after Flight Recorder.
Bug:https://bugs.openjdk.java.net/browse/JDK-8203221
WebRev:http://cr.openjdk.java.net/~ihse/JDK-8203221-makefile-fixes-after-flight-recorder/webrev.01
/Magnus
