Looks good to me.
-phil.
On 05/25/2018 10:59 AM, Erik Joelsson wrote:
Hello,
Valid point. Reordered the versions search order.
I also noticed that there is a new build failure caused by a warning
in a test. This patch disables the warning. There is a bug filed for
fixing it already:
https://bugs.openjdk.java.net/browse/JDK-8203802
New webrev: http://cr.openjdk.java.net/~erikj/8203795/webrev.02/
/Erik
On 2018-05-24 15:52, Philip Race wrote:
# The order of these defines the priority by which we try to find them.
-VALID_VS_VERSIONS="2013 2012 2010 2015 2017"
+VALID_VS_VERSIONS="2017 2015 2013 2012 2010"
I think it better to have VS2013 as the 2nd option since 2015
was never an official compiler and people might have 2015 configs that
are not suitable in some way but it did not matter before ..
-phil
On 5/24/18, 3:26 PM, Erik Joelsson wrote:
Now that we have support for building with VS2017, it's time to
change the default compiler picked up by the configure script to
VS2017.
Oracle is also changing the version used internally, by updating
jib-profiles.js
Webrev: http://cr.openjdk.java.net/~erikj/8203795/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8203795
/Erik
