I reviewed the delta-webrev (v3). Looks good. Thanks for fixing
missing newlines in launcher.properties
Mandy
On 5/30/18 12:00 PM, Jonathan Gibbons wrote:
Please review a minor update to the proposed implementation of JEP 330.
The primary change is to disallow the use of the "shebang" feature in
Java source files
(i.e. files whose name ends in ".java") as recently proposed on this
list [1].
There is some additional minor cleanup to the launcher -help text.
In the webrev, the overall changes can be seen in the main webrev index.
The recent changes can be see in the delta-webrev named "v3" in the main
webrev index page.
JEP: http://openjdk.java.net/jeps/330
JBS: https://bugs.openjdk.java.net/browse/JDK-8201274
CSR: https://bugs.openjdk.java.net/browse/JDK-8201275
Webrev: http://cr.openjdk.java.net/~jjg/8201274/webrev.mq/
-- Jon
[1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-May/001248.html
On 04/12/2018 01:15 PM, Jonathan Gibbons wrote:
Please review an initial implementation for the feature described in
JEP 330: Launch Single-File Source-Code Programs.
The work is described in the JEP and CSR, and falls into various parts:
* The part to handle the new command-line options is in the native
Java launcher code.
* The part to invoke the compiler and subsequently execute the code
found in the source file is in a new class in the jdk.compiler
module.
* There are some minor Makefile changes, to add support for a new
resource file.
There are no changes to javac itself.
JEP: http://openjdk.java.net/jeps/330
JBS: https://bugs.openjdk.java.net/browse/JDK-8201274
CSR: https://bugs.openjdk.java.net/browse/JDK-8201275
Webrev: http://cr.openjdk.java.net/~jjg/8201274/webrev.00/
-- Jon
