Looks good to me. /Magnus
> 13 juni 2018 kl. 10:28 skrev Thomas Stüfe <thomas.stu...@gmail.com>: > > Thank you Matthias! > > I'll wait for someone from the Oracle Build Group to have a say. > > ..Thomas > > On Wed, Jun 13, 2018 at 9:43 AM, Baesken, Matthias > <matthias.baes...@sap.com> wrote: >> Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) . >> >> Best regards, Matthias >> >> >> >>> -----Original Message----- >>> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- >>> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe >>> Sent: Mittwoch, 13. Juni 2018 08:14 >>> To: build-dev <build-dev@openjdk.java.net>; ppc-aix-port- >>> d...@openjdk.java.net >>> Subject: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build) >>> >>> Hi all, >>> >>> may I have reviews for this small build fix: >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8204935 >>> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8204935-aix-toc- >>> overflow/webrev.00/webrev/ >>> >>> We finally have reached the point where even the standard (not gtest) >>> release build libjvm.so got too large and blew its TOC. Hurray for >>> templates. On the bright side, no need to keep different flags for >>> different libjvm variants anymore. >>> >>> Kudos to whoever added auto-automake to the build, that makes these >>> kind of changes really easier :) >>> >>> Thank you, >>> >>> Best Regards, Thomas
