Hi Matthias, Good catch. Patch for me is good if you guys agree on a good uncommon name.
Gruß Thomas On Fri, Jun 15, 2018, 09:48 Baesken, Matthias <matthias.baes...@sap.com> wrote: > Please review this small change that fixes the AIX build after > "8203641: Refactor String Deduplication into shared" . > > We are getting this compilation error : > /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp", > line 107.38: 1540-0063 (S) The text "1" is unexpected. > > > Looks like the name of the second template parameter (STAT) > > template <typename QUEUE, typename STAT> > static void initialize_impl(); > > is clashing with defines from the AIX system headers (where I find > #define STAT 1 ) . > Renaming STAT to something else fixes the build on AIX . > > Webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/ > > Bug : > > https://bugs.openjdk.java.net/browse/JDK-8205091 > > > Thanks, Matthias >
