(reviving an old review thread)
On 2018-05-25 18:17, Erik Joelsson wrote:
On 2018-05-25 06:52, Tim Bell wrote:
Magnus-
On 05/25/18 04:23, Claes Redestad wrote:
On 2018-05-25 12:06, Magnus Ihse Bursie wrote:
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8200867-remove-jdk9-references/webrev.01
Looks good to me!
/Claes
Looks good!
doc/building.md
doc/building.html
These files also have changes to minimum gcc versions
(4.7/4.8/4.9.2/7.3.0) - is that for a different bug number?
I believe he is just updating outdated numbers in the doc that he
stumbled on. The changes are all correct.
You are correct.
However, when all dust has settled with the new compiler upgrades (and
possibly removal of support for older configurations) we should make
sure that the build documentation is correct and up to date. I'm passing
that ball on to you, Erik. :-)
/Magnus
/Erik
Looks good to me otherwise.
/Tim
