Hi all,
[Including build-dev also since this includes build related changes].
Requesting reviews for:
https://bugs.openjdk.java.net/browse/JDK-8189429 (SA: MacOSX: Replace
the deprecated PT_ATTACH with PT_ATTACHEXC)
Webrev: http://cr.openjdk.java.net/~jgeorge/8189429/webrev.04/
This is the follow-up solution for the temporary restoration of
PT_ATTACH to fix https://bugs.openjdk.java.net/browse/JDK-8184042
(several serviceability/sa tests timed out on MacOS X), which was done
in Oct 2017. The mails related to this are at:
http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-August/021702.html
Changes as compared to the patch sent last year
(http://cr.openjdk.java.net/~jgeorge/8184042/webrev.00/):
* Addressed the review comments which were provided by Poonam, Dan, Dmitry.
* A major change as compared to what was done last year is that the MIG
generated files have been included as a part of the JDK build process.
* The test case which was provided in the patch last year is no longer
required since we have ClhsdbAttach.java testing the same functionality
as a part of the SA testsuite now.
* Other than that, some minor improvements have been done wrt error
handling.
The steps for the proposed solution have been provided in JBS.
Testing: ALL the SA tests pass on MacOSX and the other Mach5 platforms.
Thanks to Sharath, Robin, Gerard and Dan for looking into the changes
and providing valuable comments.
Thanks,
Jini.
