On 7/2/18 3:28 PM, Igor Ignatyev wrote:
Vladimir,

there are two different configure-time problems:
- 1st is ability to get unbuildable configuration w/ AOT but w/o JVMCI
  - 2nd is not getting configure time warnings when Graal is enabled, but 3rd 
party libs aren't available for tests.

AFAIU,  8206135 is about 1st problem, and I, as David, expected 2nd problem to 
be addressed by 8206113. if you are planning to change the scope of 8206135, 
its title and descriptions should be changed correspondingly.

Yes, I talked only about 1st issue and I will fix only it.

What 3rd party libs you are you talking about?

Thanks
Vladimir


Thanks,
-- Igor

On Jul 2, 2018, at 2:19 PM, Vladimir Kozlov <vladimir.koz...@oracle.com> wrote:

On 7/2/18 2:17 PM, David Holmes wrote:
Hi Katya,
On 3/07/2018 5:10 AM, Ekaterina Pavlova wrote:
Hi All,

please review this extra small change which makes make more silent by
removing info message in case graal unit tests are not built.
Happy to see the build-time warning go, but I thought it was going to be 
replaced by some kind of configure-time warning?

I will fix it in jdk12:

JDK-8206135: Building jvm with AOT but without JVMCI should fail at configure 
time.

https://bugs.openjdk.java.net/browse/JDK-8206135

Vladimir

Thanks,
David
      JBS: https://bugs.openjdk.java.net/browse/JDK-8206113
   webrev: http://cr.openjdk.java.net/~epavlova//8206113/webrev.00/index.html

thanks,
-katya

p.s.
   Igor Ignatyev volunteered to sponsor this change.

Reply via email to