> On Jul 18, 2018, at 1:46 PM, Erik Joelsson <erik.joels...@oracle.com> wrote:
>
> Hello Christian,
>
> Sometimes we need hooks both close to the beginning and close to the end of
> the file, and in that case we create a SourceBundle-post.gmk. The recommended
> position of the post inclusion is right before the typical "all: $(TARGETS)"
> declaration. This file has the all target depend explicitly on a list of
> phony targets and no TARGETS variable, so I would recommend changing that to
> building a TARGETS variable like we usually do. That way you can create a
> SourceBundle-post.gmk and clear the TARGETS variable from any targets you
> don't want to run from the open file. Does that sound ok?
Yes, that would be great. In JDK 11, please :-)
>
> /Erik
>
>
> On 2018-07-18 10:31, Christian Thalinger wrote:
>> Here at Twitter our OpenJDK clone lives in a GIT repository and we would
>> like to use the source-revision feature of the release file.
>>
>> I have all the custom extension logic in place to create the revision
>> tracker:
>>
>> $ cat
>> build/macosx-x86_64-normal-server-release/support/src-rev/source-revision-tracker
>> .:ea60d3b1efc0
>>
>> but the way make/SourceRevision.gmk is structured (the custom extensions is
>> included at the top of the file) always triggers the warning:
>>
>> $ make
>> Building target 'default (exploded-image)' in configuration
>> 'macosx-x86_64-normal-server-release'
>> Warning: No mercurial configuration present and no .src-rev
>> Finished building target 'default (exploded-image)' in configuration
>> 'macosx-x86_64-normal-server-release'
>>
>> Is there a way so silence the warning without restructuring the upstream
>> file? And if no, can we change it so it works?
>
