Erik, Many thanks for looking at this change!
I can totally add the VERSION_EXTRAX variables to the spec.gmk file. Related: I was not sure what to do with VERSION_NUMBER_ALL_POSITIONS. Right now, VERSION_NUMBER_FOUR_POSITIONS is exposed to the spec.gmk file but I'm not sure exactly where it’s used. Is it worth also exposing VERSION_NUMBER_ALL_POSITIONS? I didn’t to make sure that anything that relies on VERSION_NUMBER_FOUR_POSITIONS having exactly four numbers didn’t break (and I’m happy to leave it as is). Tony ————— Tony Printezis | @TonyPrintezis | tprinte...@twitter.com On July 19, 2018 at 3:02:26 PM, Erik Joelsson (erik.joels...@oracle.com) wrote: Hello Tony, I think this looks ok. We like to keep AC_SUBST calls paired with variables in spec.gmk.in so please add corresponding VERSION_EXTRAX variables there. /Erik On 2018-07-19 11:46, Tony Printezis wrote: > Hi all, > > Here’s the webrev for this: > > http://cr.openjdk.java.net/~tonyp/8207849/webrev.0/ > > I’m no configure expert so I basically did a cut-and-paste of what was > already there. If there’s a way to do this better (maybe, cut down on the > awkward code replication), let let me know. > > The decision to allow up to 3 extra numbers was arbitrary. I can do more or > fewer. > > Tony > > ————— > Tony Printezis | @TonyPrintezis | tprinte...@twitter.com
