Thanks , can I have a second review please ? Best regards, Matthias
From: Lindenmaier, Goetz Sent: Donnerstag, 30. August 2018 14:17 To: Baesken, Matthias <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <[email protected]> Cc: Doerr, Martin <[email protected]> Subject: RE: RFR : 8210205 : build fails on AIX in hotspot cpp tests (for example getstacktr001.cpp) Hi Matthias, Aix is a nuisance. Thanks for fixing this. Looks good. As this is a build fix, and only changes tests, I think you don't need to follow the 24h rule, i.e., you can push it sooner. Best regards, Goetz. From: Baesken, Matthias Sent: Donnerstag, 30. August 2018 13:21 To: '[email protected]' <[email protected]<mailto:[email protected]>>; '[email protected]' <[email protected]<mailto:[email protected]>> Cc: Lindenmaier, Goetz <[email protected]<mailto:[email protected]>>; Doerr, Martin <[email protected]<mailto:[email protected]>> Subject: RFR : 8210205 : build fails on AIX in hotspot cpp tests (for example getstacktr001.cpp) Hello, please review this small fix to repair our AIX build . Recent changes to jdk/jdk broke the build . We get clashes with defines from system headers in a few compilation units, for example : "/openjdk/nb/rs6000_64/nightly/jdk/test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetStackTrace/getstacktr001/getstacktr001.cpp", line 69.9: 1540-0848 (S) The macro name "NUMBER_OF_FRAMES" is already defined with a different definition. "/usr/include/sys/mstsave.h", line 260.9: 1540-0425 (I) "NUMBER_OF_FRAMES" is defined on line 260 of "/usr/include/sys/mstsave.h". Renaming NUMBER_OF_FRAMES fixes the issue. Bug : https://bugs.openjdk.java.net/browse/JDK-8210205 webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8210205/ Thanks, Matthias
