Hello,
I do agree with your points.
http://cr.openjdk.java.net/~erikj/8210519/webrev.02/
On 2018-09-11 11:32, Mikael Vidstedt wrote:
Looks good, thanks for fixing.
Arguably the ":((hg)|(git)):[a-z0-9]*\\+?” string could be a constant (re-)used in
the two places it occurs, and the nested if statements inside checking the Oracle
specific part could be turned around to check "if (isOpenJDK)” first to avoid the
negation, but that’s just my preference.
Cheers,
Mikael
On Sep 10, 2018, at 3:09 PM, Erik Joelsson <[email protected]> wrote:
When I added support for git as SCM in the build, I forgot to update the test
that verifies the release file contents. This patch updates the test to also
look for hg/git in the SOURCE strings. While there I also made the test more
strict on the format and less strict when run against non Oracle produced
builds where we probably shouldn't be making assumptions on what extra
repositories may be involved and included in the SOURCE line.
Bug: https://bugs.openjdk.java.net/browse/JDK-8210519
Webrev: http://cr.openjdk.java.net/~erikj/8210519/webrev.01/
/Erik
