On Thu, Sep 13, 2018 at 12:48 PM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> wrote:
>> >> http://cr.openjdk.java.net/~martin/webrevs/jdk/noexecstack/noexecstack.patch > > I'm not entirely happy, but it'll have to do. The problem here is that the > underlying structure of the flags handling is still not good so this > probably cannot be expressed better than this. We're not entirely happy either. A much higher interface might look like TRY_ADD_LINKER_FLAGS -z noexecstack which would add -Wl,-z,noexecstack to LDFLAGS when appropriate .... hmmm ... I only just noticed that both gcc and clang accept simply $CC -z noexecstack (it's even documented!) Should we switch to that instead? > Do you have a JBS issue? I have https://bugs.openjdk.java.net/browse/JDK-8205457 gcc and clang should use the same ld flags but the proposed patch only addresses part of that. I could create a sub-task (but I've never done that before) or a new bug or change the description of this bug. What do you think?