Hi Aleksey,
re break vs. ShouldNotReachHere(), I tried to change semantics as little as
possible. After discussion with colleagues, we concluded that
ShouldNotReachHere() is the better choice. Code was modified accordingly. Your
concerns re. coding style are reflected in the new webrev as well. It can be
found here: http://cr.openjdk.java.net/~lucy/webrevs/8211145.02/
Regards,
Lutz
On 27.09.18, 12:17, "Aleksey Shipilev" <sh...@redhat.com> wrote:
On 09/27/2018 12:08 PM, Schmidt, Lutz wrote:
> Hi Aleksey & All,
>
> I have changed the "sneaky" code such that it now looks more "enterprise
grade". Please find an updated webrev at
> Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8211145.01/
Looks much better, thanks.
Should the switches over BasicType in sharedRuntime_s390.cpp be defaulted
to ShouldNotReachHere(),
like they are in sharedRuntime_ppc.cpp?
-Aleksey
