Hi Aleksey, sounds great - thanks for looking into this JFR generating stuff
and figuring out what to do where 😊 !
So I guess we do not need my AIX-related patch any more ,
after your change is in ( and the commit-with parameters calls get
usable as well on the non - JFR platforms ).
I think we could simplify then quite a few places in the hs codebase that
deal with JFR events ( where currently set_*(param1) + ... set_*(param_n) +
commit() is used, this could be just
commit(param1,...param_n) instead ) .
However this is probably out of scope of my (and your ) patch .
Best regards, Matthias
> -----Original Message-----
> From: Aleksey Shipilev <sh...@redhat.com>
> Sent: Donnerstag, 27. September 2018 20:03
> To: Baesken, Matthias <matthias.baes...@sap.com>; Thomas Schatzl
> <thomas.scha...@oracle.com>; 'hotspot-...@openjdk.java.net' <hotspot-
> d...@openjdk.java.net>; 'build-dev@openjdk.java.net' <build-
> d...@openjdk.java.net>
> Subject: Re: RFR : 8211213: fix aix build after 8196341: Add JFR events for
> parallel phases of G1
>
> On 09/27/2018 04:39 PM, Baesken, Matthias wrote:
> > Hi Thomas, do you know some fast and helpful person who can bring the
> INCLUDE_JFR and ! INCLUDE_JFR cases in sync ?
> > (or maybe there was a reason to have these differences we observe ? )
>
> I am not a JFR person, but I think this should do it -- I copied
> printCommitMethod into
> printEmptyEvent and gutted it:
> http://cr.openjdk.java.net/~shade/8211213/webrev.01/
>
> This fixes x86_64 Zero build.
>
> -Aleksey
