Hi Erik, On Fri, 2018-10-12 at 09:09 -0700, Erik Joelsson wrote: > Looks good to me. > > I wonder why only this library has that flag. Perhaps something that > should be applied more generally or not at all? (In a followup of > course)
Thanks for the review! I suppose the original intention was to help find coding problems (useful for devel builds). Cheers, Severin > /Erik > > > On 2018-10-12 02:20, Severin Gehwolf wrote: > > Hi, > > > > Please review this fix for a build failure of saproc.dll on Windows > > 32 > > bit. For 32 bit Windows builds flag -RTC1 gets added > > unconditionally. > > Yet, as per compiler doc[1] it should only be added for development > > builds. This causes a build failure post JDK-8210647 as in > > release/fastdebug variant builds of the JDK saproc.dll will get > > optimization flags producing an incompatible set of flags. This > > used to > > work prior JDK-8210647, because saproc.dll was never optimized (not > > even in release/fastdebug variants). > > > > The proposed fix is to only add the flag for slowdebug builds, > > which > > corresponds to development builds in OpenJDK. Thoughts? > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8212110 > > webrev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/webrev.01/ > > > > Unfortunately, I don't have a system to actually test this on. So > > will > > rely on Martin or Matthias to test whether this fixes the build > > failure > > [2] they are seeing. AFAIK, Oracle no longer builds on Windows 32 > > bit > > either. > > > > Thanks, > > Severin > > > > [1] https://msdn.microsoft.com/en-us/library/8wtf2dfz.aspx > > [2] > > http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2018-October/000213.html > > > >
