Hi, Lance and Erik.
Thanks for the super-speedy reviews. Pushed. iris From: Lance Andersen Sent: Thursday, October 25, 2018 1:48 PM To: Iris Clark <iris.cl...@oracle.com> Cc: build-dev@openjdk.java.net; Jonathan Gibbons <jonathan.gibb...@oracle.com> Subject: Re: RFR(XS): 8212994: Links to Oracle websites should use "https:" +1 On Oct 25, 2018, at 4:33 PM, Iris Clark <HYPERLINK "mailto:iris.cl...@oracle.com"iris.cl...@oracle.com> wrote: Hi. Please review changes to use "https" instead of "http" for links in the generated JavaDoc API pages: 8212994: Links to Oracle websites should use "https:" bug: https://bugs.openjdk.java.net/browse/JDK-8212994 webrev: https://cr.openjdk.java.net/~iris/8212994/webrev/ I did a full "make docs" build and verified that the old links are no longer in the created image. Thanks, iris $ pwd /u/iris/se/full-jdk/build/images $ find . -name "*.html" -print | xargs grep "http://www.oracle.com/technetwork/java/redist-137594.html" | wc -l 0 $ find . -name "*.html" -print | xargs grep "https://www.oracle.com/technetwork/java/redist-137594.html" | wc -l 20312 ## link in banner and footer $ find . -name "*.html" -print | xargs grep "http://www.oracle.com/technetwork/java/javase/terms/license/java12speclicense.html" | wc -l 0 $ find . -name "*.html" -print | xargs grep "https://www.oracle.com/technetwork/java/javase/terms/license/java12speclicense.html" | wc -l 40624 $ find . -name "*.html" -print | xargs grep "http://bugreport.java.com/bugreport/" | wc -l 0 $ find . -name "*.html" -print | xargs grep "https://bugreport.java.com/bugreport/" | wc -l 20312 $ find . -name "*.html" -print | xargs grep "http://www.oracle.com/pls/topic/lookup?ctx=javase12\&\;id=homepage" | wc -l 0 $ find . -name "*.html" -print | xargs grep "https://www.oracle.com/pls/topic/lookup?ctx=javase12\&\;id=homepage" | wc -l 20312 http://oracle.com/us/design/oracle-email-sig-198324.gif HYPERLINK "http://oracle.com/us/design/oracle-email-sig-198324.gif" Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 HYPERLINK "mailto:lance.ander...@oracle.com"lance.ander...@oracle.com