On 2018-11-01 11:26, Lance Andersen wrote:
+1
Thanks, Lance!
/Magnus
On Nov 1, 2018, at 6:06 AM, Magnus Ihse Bursie
<[email protected]
<mailto:[email protected]>> wrote:
In JDK-8210958, a broken version of jib-profiles.js was unfortunately
checked in.
The change at
http://cr.openjdk.java.net/~ihse/JDK-8210958-rename-run-test-to-test/webrev.02/make/conf/jib-profiles.js.udiff.html,
as reviewed, was unfortunately reverted in the process.
Without this fix, the *-testmake profiles fails when run.
Bug: https://bugs.openjdk.java.net/browse/JDK-8213237
Patch inline:
diff --git a/make/conf/jib-profiles.js b/make/conf/jib-profiles.js
--- a/make/conf/jib-profiles.js
+++ b/make/conf/jib-profiles.js
@@ -485,7 +485,7 @@
.forEach(function (name) {
var maketestName = name + "-testmake";
profiles[maketestName] = concatObjects(profiles[name],
testmakeBase);
- profiles[maketestName].default_make_targets = [
"test-make", "test-compile-commands" ];
+ profiles[maketestName].default_make_targets = [
"test-make" ];
});
// Profiles for building the zero jvm variant. These are used
for verification.
/Magnus
(Sorry for the mess :-()
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
