> On Nov 6, 2018, at 6:55 AM, Kim Barrett <kim.barr...@oracle.com> wrote: > >> On Nov 6, 2018, at 6:16 AM, Magnus Ihse Bursie >> <magnus.ihse.bur...@oracle.com> wrote: >> >> In JDK-8211073, an attempt was made to add -Wextra to hotspot. That patch >> was not accepted at the time being, but it did dig out some bugs in the code. >> >> While we await JDK-8211073 to be included in the code base (so -Wextra is >> always on), we can at least fix the bugs it found in some copy constructors. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8213414 >> WebRev: >> http://cr.openjdk.java.net/~ihse/JDK-8213414-fix-hotspot-copy-constructors/webrev.01 >> >> /Magnus > > Looks good.
… and trivial.