Looks ok to me. /Erik
On 2018-11-15 06:57, Severin Gehwolf wrote:
Hi, Could I please get reviews for this 8u backport of JDK-8210647. Since the build system is different in 8, the patch looks different. For the Windows build changes I've refactored the make file a bit so as to facilitate passing opt flags to the compiler. Bug: https://bugs.openjdk.java.net/browse/JDK-8210647 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210647/jdk8/webrev.02/ Testing: We have been using this in Fedora's JDK 8 for a while now and haven't seen any issues. Same for the JDK 12 fix. Alex Kashchenko was kind enough to test this on Windows. Note: I'll also plan to backport JDK-8210836 and JDK-8212110 Thanks, Severin
