I don't have anything further to add. The best person to update these
docs is the person trying to use them for the first time :)
Thanks,
David
On 16/11/2018 4:35 am, Sergey wrote:
Erik,
Thanks for a quick response!
The defpath part is not obsolete, but "forest" -> "repository" should
probably be applied to the whole file. The last section about "trees" is
certainly obsolete however.
Ok, got it! Thanks for clarification!
As long as you are generating the html version using "make
update-build-docs" (for which you need pandoc, preferably version
1.17.2), we don't need to see the html version. It's not meant to be
edited by hand.
Oh, all right, I thought, that as long as it is version controlled I need
to
change it and send the diff for that one as well. I'll send a patch then for
*building.md* only.
Btw, have you signed the OCA?
Yes, sure, you could find me here [1]
In the mean time I want to wait for quite a bit and send consolidated
update if David would have anything else changed.
Thanks,
su -
[1] https://www.oracle.com/technetwork/community/oca-486395.html#u
On Thu, 15 Nov 2018 at 17:56, Erik Joelsson <erik.joels...@oracle.com>
wrote:
Hello Sergey,
On 2018-11-15 07:41, Sergey wrote:
Hi Erik, David,
Thanks for review comments! I've almost addressed them,
however, I have a question worth asking before finalizing a patch.
At the *building.md:1396* [1] (as well as in it's html alter-ego) there's
a section:
### Setting Up a Forest for Pushing Changes (defpath)
I believe it is obsolete and could be safely deleted, or am I missing
something?
The defpath part is not obsolete, but "forest" -> "repository" should
probably be applied to the whole file. The last section about "trees" is
certainly obsolete however.
And one more thing about the patches themselves. As
patches aren't that compact anymore, should I send updated
diffs for *building.md* && *building.html* in the separate
mails, or it will be fine if I just inline them alltogether?
As long as you are generating the html version using "make
update-build-docs" (for which you need pandoc, preferably version
1.17.2), we don't need to see the html version. It's not meant to be
edited by hand.
Btw, have you signed the OCA?
/Erik
Thanks,
su -
[1]
http://hg.openjdk.java.net/jdk/sandbox/file/a2413ed39eff/doc/building.md#l1396
