Hi Magnus, Thanks! By the way, I finally received that email after hours:)
Cheers, Ao Qi On Mon, Dec 10, 2018 at 10:20 PM Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> wrote: > > On 2018-12-10 13:07, Ao Qi wrote: > > Hi Magnus, > > > > It is strange that I saw your reply in "build-dev Archives" [1], but I > > did not receive the email. Maybe there is something wrong with my > > email server. I cannot reply to your email directly. > Sometimes the mailing list servers seem to lose mail, or hold them for > arbitrarily long time before sending them on. It's happening for me > every once in a while. Hmm... On the other hand, this time I got my own > mail to the list, and you were cc:ed too, so you should definitely have > received it. Probably an issue on your side, yes. > > > > Thanks for your review. To answer your question: > > > >> I assume you need a sponsor for this? Have you signed the OCA, and do > >> you have an OpenJDK user name? (Sorry if I asked you before.) > > Yes. Yes. No. One of my previous patch[2] for your reference. > > > > > > [1] > > http://mail.openjdk.java.net/pipermail/build-dev/2018-December/024326.html > > [2] http://hg.openjdk.java.net/jdk/jdk/rev/04c8eba70a59 > Thanks! I pushed this as JBS-8215129. > > /Magnus > > > > Cheers, > > Ao Qi > > On Mon, Dec 10, 2018 at 6:28 PM Ao Qi <a...@loongson.cn> wrote: > >> Hi all, > >> > >> When I try to do a cross-compiling with qemu-deboostrap according to > >> doc/building.html, it failed to configure (a X11 headers error, > >> "checking for X11/extensions/Xrandr.h... no"). > >> > >> I think it is because Xrandr became a configure check prerequisite > >> after JDK-8213944. Could anyone please review this tiny fix for the > >> build documentation? > >> > >> Cheers, > >> Ao Qi > >> > >> $ hg diff -g doc > >> diff --git a/doc/building.html b/doc/building.html > >> --- a/doc/building.html > >> +++ b/doc/building.html > >> @@ -396,9 +396,9 @@ > >> <h3 id="x11">X11</h3> > >> <p>Certain <a href="http://www.x.org/";>X11</a> libraries and include > >> files are required on Linux and Solaris.</p> > >> <ul> > >> -<li>To install on an apt-based Linux, try running <code>sudo apt-get > >> install libx11-dev libxext-dev libxrender-dev libxtst-dev > >> libxt-dev</code>.</li> > >> -<li>To install on an rpm-based Linux, try running <code>sudo yum > >> install libXtst-devel libXt-devel libXrender-devel > >> libXi-devel</code>.</li> > >> -<li>To install on Solaris, try running <code>pkg install > >> x11/header/x11-protocols x11/library/libice > >> x11/library/libpthread-stubs x11/library/libsm x11/library/libx11 > >> x11/library/libxau x11/library/libxcb x11/library/libxdmcp > >> x11/library/libxevie x11/library/libxext x11/library/libxrender > >> x11/library/libxscrnsaver x11/library/libxtst > >> x11/library/toolkit/libxt</code>.</li> > >> +<li>To install on an apt-based Linux, try running <code>sudo apt-get > >> install libx11-dev libxext-dev libxrender-dev libxrandr-dev > >> libxtst-dev libxt-dev</code>.</li> > >> +<li>To install on an rpm-based Linux, try running <code>sudo yum > >> install libXtst-devel libXt-devel libXrender-devel libXrandr-devel > >> libXi-devel</code>.</li> > >> +<li>To install on Solaris, try running <code>pkg install > >> x11/header/x11-protocols x11/library/libice > >> x11/library/libpthread-stubs x11/library/libsm x11/library/libx11 > >> x11/library/libxau x11/library/libxcb x11/library/libxdmcp > >> x11/library/libxevie x11/library/libxext x11/library/libxrender > >> x11/library/libxrandr x11/library/libxscrnsaver x11/library/libxtst > >> x11/library/toolkit/libxt</code>.</li> > >> </ul> > >> <p>Use <code>--with-x=<path></code> if <code>configure</code> > >> does not properly locate your X11 files.</p> > >> <h3 id="alsa">ALSA</h3> > >> @@ -662,6 +662,7 @@ > >> <li>libice-dev</li> > >> <li>libxrender</li> > >> <li>libxrender-dev</li> > >> +<li>libxrandr-dev</li> > >> <li>libsm-dev</li> > >> <li>libxt-dev</li> > >> <li>libx11</li> > >> @@ -693,7 +694,7 @@ > >> <pre><code>apt install g++-aarch64-linux-gnu > >> gcc-aarch64-linux-gnu</code></pre></li> > >> <li><p>Create chroot on the <em>build</em> system, configuring it for > >> <em>target</em> system:</p> > >> <pre><code>sudo qemu-debootstrap --arch=arm64 --verbose \ > >> - > >> --include=fakeroot,build-essential,libx11-dev,libxext-dev,libxrender-dev,libxtst-dev,libxt-dev,libcups2-dev,libfontconfig1-dev,libasound2-dev,libfreetype6-dev,libpng12-dev > >> \ > >> + > >> --include=fakeroot,build-essential,libx11-dev,libxext-dev,libxrender-dev,libxrandr-dev,libxtst-dev,libxt-dev,libcups2-dev,libfontconfig1-dev,libasound2-dev,libfreetype6-dev,libpng12-dev > >> \ > >> --resolve-deps jessie /chroots/arm64 > >> http://httpredir.debian.org/debian/</code></pre></li> > >> <li><p>Configure and build with newly created chroot as > >> sysroot/toolchain-path:</p> > >> <pre><code>CC=aarch64-linux-gnu-gcc CXX=aarch64-linux-gnu-g++ sh > >> ./configure --openjdk-target=aarch64-linux-gnu > >> --with-sysroot=/chroots/arm64/ --with-toolchain-path=/chroots/arm64/ > >> diff --git a/doc/building.md b/doc/building.md > >> --- a/doc/building.md > >> +++ b/doc/building.md > >> @@ -488,15 +488,15 @@ > >> Linux and Solaris. > >> > >> * To install on an apt-based Linux, try running `sudo apt-get install > >> - libx11-dev libxext-dev libxrender-dev libxtst-dev libxt-dev`. > >> + libx11-dev libxext-dev libxrender-dev libxrandr-dev libxtst-dev > >> libxt-dev`. > >> * To install on an rpm-based Linux, try running `sudo yum install > >> - libXtst-devel libXt-devel libXrender-devel libXi-devel`. > >> + libXtst-devel libXt-devel libXrender-devel libXrandr-devel > >> libXi-devel`. > >> * To install on Solaris, try running `pkg install > >> x11/header/x11-protocols > >> x11/library/libice x11/library/libpthread-stubs x11/library/libsm > >> x11/library/libx11 x11/library/libxau x11/library/libxcb > >> x11/library/libxdmcp x11/library/libxevie x11/library/libxext > >> - x11/library/libxrender x11/library/libxscrnsaver x11/library/libxtst > >> - x11/library/toolkit/libxt`. > >> + x11/library/libxrender x11/library/libxrandr x11/library/libxscrnsaver > >> + x11/library/libxtst x11/library/toolkit/libxt`. > >> > >> Use `--with-x=<path>` if `configure` does not properly locate your X11 > >> files. > >> > >> @@ -1062,6 +1062,7 @@ > >> * libice-dev > >> * libxrender > >> * libxrender-dev > >> + * libxrandr-dev > >> * libsm-dev > >> * libxt-dev > >> * libx11 > >> @@ -1112,7 +1113,7 @@ > >> * Create chroot on the *build* system, configuring it for *target* > >> system: > >> ``` > >> sudo qemu-debootstrap --arch=arm64 --verbose \ > >> - > >> --include=fakeroot,build-essential,libx11-dev,libxext-dev,libxrender-dev,libxtst-dev,libxt-dev,libcups2-dev,libfontconfig1-dev,libasound2-dev,libfreetype6-dev,libpng12-dev > >> \ > >> + > >> --include=fakeroot,build-essential,libx11-dev,libxext-dev,libxrender-dev,libxrandr-dev,libxtst-dev,libxt-dev,libcups2-dev,libfontconfig1-dev,libasound2-dev,libfreetype6-dev,libpng12-dev > >> \ > >> --resolve-deps jessie /chroots/arm64 > >> http://httpredir.debian.org/debian/ > >> ``` >
