Hi Magnus, Thanks for the info! That indeed doesn't make much sense rolling in such a patch then.
Cheers, Sergei On Mon, Dec 31, 2018, 09:14 Magnus Ihse Bursie < [email protected] wrote: > The hsdis build is planned for rewrite. I'd rather not make hacky fixes > like this. > > /Magnus > > > 31 dec. 2018 kl. 00:42 skrev Sergei Ustimenko <[email protected]>: > > > > Eh, please disregard the pattern from the previous mail. I mean is it > worth > > ignoring something more specific like "/src/utils/hsdis/build". > > > >> On Sun, Dec 30, 2018, 23:48 Sergei Ustimenko <[email protected] wrote: > >> > >> Hi David, > >> > >> Whoops, indeed it exists. Perhaps then something like > >> "src/utils/**/build" would be better? > >> > >> The reason I raise it is that I've eventually stumbled upon > >> quite an excessive output of `hg status`. Perhaps that is > >> something worth fixing. > >> > >> Thanks, > >> Sergei > >> > >> On Sun, 30 Dec 2018 at 22:24, David Holmes <[email protected]> > >> wrote: > >> > >>> Hi, > >>> > >>>> On 31/12/2018 4:43 am, Sergei Ustimenko wrote: > >>>> Hi, > >>>> > >>>> I was recently building hsdis at src/utils/hsdis and found out that > >>>> the build/ directory here is not ignored. Ignore pattern in .hgignore > >>>> is "^build/" and in .gitignore it is "build/" respectively. > >>>> > >>>> I wonder if pattern could be extended to ignore at least > >>>> "src/**/build" like in the patch below: > >>> > >>> Nope because: > >>> > >>> src/utils/src/build/ > >>> > >>> exists. > >>> > >>> Cheers, > >>> David > >>> > >>>> > >>>> diff --git a/.gitignore b/.gitignore > >>>> --- a/.gitignore > >>>> +++ b/.gitignore > >>>> @@ -1,4 +1,5 @@ > >>>> /build/ > >>>> +/src/**/build/** > >>>> /dist/ > >>>> /.idea/ > >>>> nbproject/private/ > >>>> diff --git a/.hgignore b/.hgignore > >>>> --- a/.hgignore > >>>> +++ b/.hgignore > >>>> @@ -1,4 +1,5 @@ > >>>> ^build/ > >>>> +^src/.*/build/.* > >>>> ^dist/ > >>>> ^.idea/ > >>>> nbproject/private/ > >>>> > >>>> > >>>> > >>>> Regards, > >>>> Sergei > >> > >
