Thanks! Pushed: https://bugs.openjdk.java.net/browse/JDK-8216267
/Erik
On 2019-01-07 10:38, Markus Gronlund wrote:
Hi Andrew and Erik,
I have just tried the patch and with it I can successfully build the make
hotspot-ide-project target in WSL.
I also verified the backwards compatibility that you are still able to perform
this build using Cygwin.
Thank you very much Andrew and Erik for your work related to WSL, much
appreciated indeed.
Cheers
Markus
-----Original Message-----
From: Erik Joelsson
Sent: den 7 januari 2019 10:13
To: Andrew Luo <[email protected]>; [email protected];
Markus Gronlund <[email protected]>
Subject: Re: [PATCH] Fix hotspot-ide-project target on WSL
Thanks Andrew for looking into this!
Markus, could you try the patch?
/Erik
On 2019-01-06 20:22, Andrew Luo wrote:
New patch, minor updates to copyright year and de-duplicating the macro code a
bit.
Thanks,
-Andrew
-----Original Message-----
From: build-dev <[email protected]> On Behalf Of Andrew Luo
Sent: Friday, January 4, 2019 8:41 PM
To: [email protected]
Subject: [PATCH] Fix hotspot-ide-project target on WSL
Subject line is self-explanatory, and patch is attached :)
Basically, I changed the makefiles to add support for wslpath to convert paths
(when in WSL, of course. Otherwise it's cygpath). For executables we call
%windir%\Sysnative\wsl.exe ... (We have to use Sysnative because of WoW64
redirection of System32).
Thanks,
-Andrew
