Please do. The lib/jli remnants has been lingering on too far in too
many places. Just be clear in the bug/commit title that this is not just
for AIX.
FWIW, your fix looks good to me.
/Magnus
On 2019-01-15 12:12, Lindenmaier, Goetz wrote:
Ah... a small add on:
There is one other reference to /jli in the code I could find:
diff -r 3d6da8a542ab -r 32af46822a7a test/hotspot/gtest/gtestMain.cpp
--- a/test/hotspot/gtest/gtestMain.cpp Mon Jan 14 17:22:23 2019 +0100
+++ b/test/hotspot/gtest/gtestMain.cpp Tue Jan 15 10:15:39 2019 +0100
@@ -224,9 +224,9 @@
// workaround for JDK-7131356
#ifdef __APPLE__
- size_t len = strlen(java_home) + strlen("/lib/jli/libjli.dylib") + 1;
+ size_t len = strlen(java_home) + strlen("/lib/libjli.dylib") + 1;
char* path = new char[len];
- snprintf(path, len, "%s/lib/jli/libjli.dylib", java_home);
+ snprintf(path, len, "%s/lib/libjli.dylib", java_home);
dlopen(path, RTLD_NOW | RTLD_GLOBAL);
#endif // __APPLE__
Should I add this to this patch, too?
Best regards,
Goetz.
-----Original Message-----
From: Lindenmaier, Goetz
Sent: Dienstag, 15. Januar 2019 12:10
To: hotspot-runtime-...@openjdk.java.net
Subject: RFR(S): 8217044: [aix] Launcher still adds old path to jli library to
LIBPATH
Hi,
As AIX does not know $ORIGIN the path to libjli must be in LIBPATH. libjli
though has been moved from lib/jli/ to lib/. The path to lib/ is added to
LIBPATH anyways, so we can remove the special case for AIX.
Please review this small cleanup.
http://cr.openjdk.java.net/~goetz/wr19/8217044-aixLauncher/01/
Best regards,
Goetz.
