Hi Erik, I don't like that it's based on the assumption that ld and clang/gcc are in the same directory, but this assumption seems to be always true for now. so unless there is an easy way to get ld path, I'm fine w/ this fix.
-- Igor > On Jan 23, 2019, at 1:18 PM, Vladimir Kozlov <vladimir.koz...@oracle.com> > wrote: > > Looks good. > > Thanks, > Vladimir > > On 1/23/19 12:03 PM, Erik Joelsson wrote: >> The TEST_OPTS=AOT_MODULES option does not work when running tests locally on >> Macosx. This is because jaot expects the linker to be "ld", while we define >> the linker (LD) to be clang on Macosx. When running tests on already built >> JDKs using run-test-prebuilt, we already setup LD to point to "ld" rather >> than "clang", so the same should be done when running local tests. >> This patch rewrites LD for jaotc, on Macosx and Linux. Though we did not >> have a problem on Linux, the run-test-prebuilt case does set LD to "ld" on >> Linux so better have it consistent. >> I also added -XX:+UnlockDiagnosticVMOptions to the verification command to >> make it work on release builds where this flag is default off, as well as >> cleaned up some whitespace. >> Bug: https://bugs.openjdk.java.net/browse/JDK-8217613 >> Webrev: http://cr.openjdk.java.net/~erikj/8217613/webrev.01/ >> /Erik
