On 2019-01-25 10:31, Langer, Christoph wrote:
Hi,
may I please get reviews for the backport of this issue to jdk11u.
Bug: https://bugs.openjdk.java.net/browse/JDK-8207849
Original Commit: http://hg.openjdk.java.net/jdk/jdk/rev/1edc62f9ba3a
Original review thread:
https://mail.openjdk.java.net/pipermail/build-dev/2018-July/022719.html
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207849.11u/
The patch did not apply cleanly, but only because in
"make/autoconf/version-numbers" some version numbers have changed in the
meanwhile and the apply tool did not find the right spot to insert the additional
variables.
Thanks
Christoph
Looks good to me.
When a patch fail to apply cleanly, I regularly try with the "wiggle"
tool. [1] It is much more resilient to harmless changes than "patch".
The backport rule of "applies cleanly" still requires you to send a RFR,
but using wiggle saves your effort, and including a note about it in the
RFR will increase reviewers confidence.
/Magnus
[1] https://github.com/neilbrown/wiggle
