Hi, this looks good, the build works with this patch. Do you need a sponsor?
Best regards, Goetz. > -----Original Message----- > From: Ichiroh Takiguchi <taki...@linux.vnet.ibm.com> > Sent: Dienstag, 29. Januar 2019 02:21 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> > Cc: build-dev <build-dev@openjdk.java.net>; ppc-aix-port-dev <ppc-aix-port- > d...@openjdk.java.net>; core-libs-...@openjdk.java.net; Baesken, Matthias > <matthias.baes...@sap.com> > Subject: RFR: JDK-8217880 AIX build issue about JDK-8214533 > > Hello. > > Sorry about build issue for JDK-8214533. > > EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8217880 > Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ > > Could you review the fix ? > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. > > On 2019-01-28 22:49, Ichiroh Takiguchi wrote: > > Hello Goetz. > > > > Thank you for your suggestion. > > I just open JDK-8217880 [1]. > > > > I just restart clean build. > > > > I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8217880 > > > > Thanks, > > Ichiroh Takiguchi > > > > On 2019-01-28 22:11, Lindenmaier, Goetz wrote: > >> Hi Ichiroh, > >> > >> just open a bug, like "Fix aix build after 8214533" and post a RFR for > >> it. > >> I assume the fix is quite trivial so we can review it quick. > >> > >> Best regards, > >> Goetz. > >> > >>> -----Original Message----- > >>> From: ppc-aix-port-dev <ppc-aix-port-dev-boun...@openjdk.java.net> On > >>> Behalf Of Ichiroh Takiguchi > >>> Sent: Montag, 28. Januar 2019 14:13 > >>> To: Baesken, Matthias <matthias.baes...@sap.com> > >>> Cc: build-dev <build-dev@openjdk.java.net>; ppc-aix-port-dev > >>> <ppc-aix-port- > >>> d...@openjdk.java.net>; core-libs-...@openjdk.java.net; Alan Bateman > >>> <alan.bate...@oracle.com> > >>> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default > >>> charset > >>> > >>> Hello. > >>> > >>> I'm very sorry. It's my fault. > >>> EUC_JP class was moved to java.base module. > >>> (sun.nio.cs.EUC_JP). > >>> > >>> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and > >>> EUC_JP_Open. > >>> > >>> Could you suggest me how I should provide new webrev files ? > >>> > >>> Thanks, > >>> Ichiroh Takiguchi > >>> > >>> > >>> On 2019-01-28 17:03, Baesken, Matthias wrote: > >>> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now > >>> > we see build errors on AIX , are they related to this change ? > >>> > > >>> > > >>> > /nb/rs6000_64/nightly/output-jdk- > >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: > >>> > error: Decoder is not public in EUC_JP; cannot be accessed from > >>> > outside package > >>> > private static class Decoder extends EUC_JP.Decoder { > >>> > ^ > >>> > /nb/rs6000_64/nightly/output-jdk- > >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: > >>> > error: Encoder is not public in EUC_JP; cannot be accessed from > >>> > outside package > >>> > private static class Encoder extends EUC_JP.Encoder { > >>> > ^ > >>> > /nb/rs6000_64/nightly/output-jdk- > >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: > >>> > error: Decoder is not public in EUC_JP; cannot be accessed from > >>> > outside package > >>> > private static class Decoder extends EUC_JP.Decoder { > >>> > ^ > >>> > /nb/rs6000_64/nightly/output-jdk- > >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: > >>> > error: Encoder is not public in EUC_JP; cannot be accessed from > >>> > outside package > >>> > private static class Encoder extends EUC_JP.Encoder { > >>> > > >>> > Best regards, Matthias > >>> > > >>> > > >>> > > >>> >> -----Original Message----- > >>> >> From: ppc-aix-port-dev <ppc-aix-port-dev-boun...@openjdk.java.net> > On > >>> >> Behalf Of Ichiroh Takiguchi > >>> >> Sent: Dienstag, 15. Januar 2019 01:51 > >>> >> To: Alan Bateman <alan.bate...@oracle.com> > >>> >> Cc: build-dev <build-dev@openjdk.java.net>; ppc-aix-port-dev <ppc-aix- > >>> >> port-...@openjdk.java.net>; core-libs-...@openjdk.java.net > >>> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default > >>> >> charset > >>> >> > >>> >> Hello Alan. > >>> >> > >>> >> Could you review the fix again ? > >>> >> > >>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 > >>> >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ > >>> >> > >>> >> I added IBM29626C charset as standard way. > >>> >> Please give any suggestion and question. > >>> >> > >>> >> Thanks, > >>> >> Ichiroh Takiguchi > >>> >> IBM Japan, Ltd. > >>> >> > >>> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: > >>> >> > Hello Alan. > >>> >> > > >>> >> > I opened JDK-8215333 for Charset filtering issue [1]. > >>> >> > I cannot wait until JDK-8215333 is closed. > >>> >> > Is it possible to put IBM-29626C charset with standard way ? > >>> >> > > >>> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 > >>> >> > > >>> >> > Thanks, > >>> >> > Ichiroh Takiguchi > >>> >> > > >>> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: > >>> >> >> Hello Roger, Magnus and Alan. > >>> >> >> I may need to put alias information into charsets file. > >>> >> >> stdcs-xxx cannot handle this information... > >>> >> >> > >>> >> >> Still AIX needs IBM-29626C charset for default encoding... > >>> >> >> > >>> >> >> I appreciate if you give me further suggestions. > >>> >> >> > >>> >> >> Thanks, > >>> >> >> Ichiroh Takiguchi > >>> >> >> > >>> >> >> On 2018-12-10 20:50, Alan Bateman wrote: > >>> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: > >>> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: > >>> >> >>>>> Hi, > >>> >> >>>>> > >>> >> >>>>> It is a nice feature that charsets are selected at build time > >>> >> >>>>> using > >>> >> >>>>> the stdcs-xxx files. > >>> >> >>>>> This change breaks that pattern and embeds os specific > information > >>> >> >>>>> in more than one place. > >>> >> >>>>> That does not seem like an improvement. Is there any > alternative? > >>> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? > >>> >> >>> My reading of the patch is that the "os" key is to avoid generating > >>> >> >>> it > >>> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on > >>> >> >>> non-AIX platforms. The general direction is welcome but I think > >>> >> >>> further work and discussion will be needed to get the right set of > >>> >> >>> changes to support filtering in the build. It can probably be > >>> >> >>> separated from the changes to add IBM-29626C to AIX's java.base. > >>> >> >>> > >>> >> >>> -Alan
