Looks good, ship it!

/Claes

On 2019-02-11 11:23, Magnus Ihse Bursie wrote:
Unfortunately I introduced a build error in JDK-8218431 (Improved platform checking). This resulted in the following error message:
lib/JvmFlags.gmk:77: extraneous text after 'ifeq' directive

This only happens for fastdebug builds, which is why I did not discover it during the testing of JDK-8218431. The fix is trivial.

Bug: https://bugs.openjdk.java.net/browse/JDK-8218736
Patch inline:
diff --git a/make/hotspot/lib/JvmFlags.gmk b/make/hotspot/lib/JvmFlags.gmk
--- a/make/hotspot/lib/JvmFlags.gmk
+++ b/make/hotspot/lib/JvmFlags.gmk
@@ -74,7 +74,7 @@
    endif
  else ifeq ($(DEBUG_LEVEL), fastdebug)
    JVM_CFLAGS_DEBUGLEVEL := -DASSERT
-  ifeq ($call isTargetOs, windows aix), false)
+  ifeq ($(call isTargetOs, windows aix), false)
     # NOTE: Old build did not define CHECK_UNHANDLED_OOPS on Windows and AIX.
      JVM_CFLAGS_DEBUGLEVEL += -DCHECK_UNHANDLED_OOPS
    endif

/Magnus

Reply via email to