CC'ing hotspot-dev. I agree this needs to be checked on every platform
affected. I can't comment on the fix itself.
David
On 20/03/2019 2:36 am, Erik Joelsson wrote:
I think this needs to be reviewed by at least someone in hotspot who
regularly builds hsdis. I can't really comment on the validity of the
patch as I'm unfamiliar with both hsdis as well as this makefile. Have
you at least verified the build on all the platforms which you affect
with this change (which would be at least Macos, AIX and Windows in a
normal Cygwin VS env)?
/Erik
On 2019-03-18 17:56, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8220784
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220784/webrev.00/
I attempt to build hsdis for Windows on WSL Ubuntu 18.04 with
gcc-mingw-w64-x86-64, but I saw error messages that some functions
which are provided by zlib are unresolved.
We need to link to zlib.
Thanks,
Yasumasa
