> On Apr 9, 2019, at 6:31 AM, Erik Joelsson <[email protected]> wrote:
>
> Hello Shura,
>
> If JCOV_FILTERS is ever expected to be set on the make command line
> (typically when running make run-test-prebuilt), then it would be good if we
> could add a way to set it through TEST_OPTS=JCOV_FILTERS=... . Using the
> officially supported input variables like this avoids the warning about
> unsupported variables you otherwise get from our makefiles.
>
> To do that, you simply add JCOV_FILTERS to the ParseKeywordVariable call for
> TEST_OPTS further up in RunTests.gmk. Then you will receive the variable as
> TEST_OPTS_JCOV_FILTERS.
Yes, the variable could be used directly.
Thank you, will fix!
Shura
>
> Otherwise this looks good.
>
> /Erik
>
> On 2019-04-08 14:12, Alexandre (Shura) Iline wrote:
>> Hi,
>>
>> Could you please take a look on this enhancement which makes it easy to get
>> code coverage for a part of JDK code.
>>
>> This change introduces “JCOV_FILTERS” make variable and also
>> "--with-jcov-filters” configuration option.
>>
>> With that one is free to use any of JCov filtering options to limit the
>> resulting report to only the desired code.
>>
>> This is an excerpt from JCov usage output:
>> Filtering conditions.
>> -include(i) 'string value' (Option could be specified several times.)
>> -exclude(e) 'string value' (Option could be specified several times.)
>> -include_list 'string value'
>> -exclude_list 'string value'
>> -include_module_list 'string value'
>> -exclude_module_list 'string value'
>> Filtering conditions.
>> -include_module(im) 'string value' (Option could be specified
>> several times.)
>> -exclude_module(em) 'string value' (Option could be specified
>> several times.)
>> -fm 'string value' (Option could be specified several times.)
>> -fm_list 'string value'
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221857
>> Webrev: http://cr.openjdk.java.net/~shurailine/JDK-8221857/webrev.00/
>>
>> Thank you.
>>
>> Shura
>>
