Hi, For Hotspot: A “trivial” HotSpot change only needs one Reviewer, and doesn’t need to wait 24 hours for other potential reviewers to chime in. https://wiki.openjdk.java.net/display/HotSpot/HotSpot+How+To [1]. Otherwise, if I remember correctly, a hotspot change needs two reviewers, and one should be Reviewer. It is written at https://wiki.openjdk.java.net/display/HotSpot/HotSpot+How+To, but https://wiki.openjdk.java.net seems under maintenance for a while.
Cheers, Ao Qi [1] https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2019-April/025321.html On Tue, Apr 16, 2019 at 2:34 PM David Holmes <[email protected]> wrote: > > On 16/04/2019 4:09 pm, Langer, Christoph wrote: > > Hi Man, > > > > the change looks good to me, thanks for doing this cleanup. > > > > As for reviewers: I thought it depends whether the author of a change is a > > Reviewer himself. Then only one Reviewer needs to review the change. But I > > might be wrong here. So, let's wait for a review from the build group and > > maybe these folks can answer this question, too. > > The rules for "number of reviews" does not depend on the status of the > changeset author but the informal rules governing the area in which the > change is made. The build folk typically only need one Review - but of > course they'd like that to be from a competent build reviewer. Hotspot > (runtime only?) like to have two reviews (but only one needs to be a > Reviewer). > > Cheers, > David > > > Best regards > > Christoph > > > >> -----Original Message----- > >> From: build-dev <[email protected]> On Behalf Of Man > >> Cao > >> Sent: Dienstag, 16. April 2019 04:04 > >> To: [email protected] > >> Subject: [DMARC FAILURE] RFR (XS): 8222510: Small cleanup for JDK > >> launcher's make file > >> > >> Hi, > >> > >> Can I have reviews for this small cleanup? It basically removes some dead > >> and redundant variables and updates comment. > >> Webrev: https://cr.openjdk.java.net/~manc/8222510/webrev.00/ > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8222510 > >> > >> I found these issues while working on the tsan project ( > >> http://hg.openjdk.java.net/tsan/dev/). Some relevant changes previously > >> touched the code include JDK-8210931, JDK-8199639, JDK-8141444. > >> > >> And do I need only one review for this change? It seems many build files > >> changes only have one reviewer. > >> > >> -Man
