I have filed JDK-8223189
<https://bugs.openjdk.java.net/browse/JDK-8223189> to address these.
/Andy
On 4/30/2019 7:02 PM, Kevin Rushforth wrote:
I have a couple nit-picky comments:
1. The change to src/jdk.jlink/share/classes/module-info.java is
unrelated to jpackage and should be reverted (there is only a
white-space change and a copyright date change to that file)
2. The following files have whitespace errors that will cause jcheck
to fail:
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java:326:
Trailing whitespace
src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java:58:
Tab character
src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java:217:
Trailing whitespace
src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java:55:
Trailing whitespace
3. I recommend to replace the wild-card imports with explicit imports,
for example:
src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java
(java.util.* and java.io.*)
(I think the wild-card static import is fine, just not the import
every class from a package)
I'll try to remember to note these as I go through the review. This
one could be done as a follow-up bug rather than doing it prior to
integration if you prefer.
-- Kevin
