Hi Erik,

Thank you for your comments. Updated the webrev accordingly:

https://cr.openjdk.java.net/~naoto/8221431/webrev.04/

Naoto

On 5/22/19 4:13 PM, Erik Joelsson wrote:
Hello Naoto,

In GensrcEmojiData.gmk: The MakeDir doesn't look correct with the double $$. I would recommend calling the newer MakeTargetDir macro instead. It doesn't take an argument.

Otherwise build changes look good.

/Erik

On 2019-05-22 15:56, naoto.s...@oracle.com wrote:
Adding build-dev, as the change adds a small build tool to parse emoji-data.

Naoto

On 5/22/19 3:26 PM, naoto.s...@oracle.com wrote:
Hi,

Please review the changes to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8221431

The proposed CSR and changeset are located at:

https://bugs.openjdk.java.net/browse/JDK-8222771
https://cr.openjdk.java.net/~naoto/8221431/webrev.03/

This enhancement incorporates support for the recently released Unicode version 12.1. Besides the usual addition of new characters/scripts, this enhancement includes normalization of the Japanese Reiwa era character (U+32FF), and up-to-date extended grapheme cluster support in regex package.

Naoto

Reply via email to