Since I added comparing of the test image, we have seen some intermittent compare failures in the baseline compare builds we run. The root cause of these failures are that the native libraries in the test image are not stripped of debug information, like the product native libraries are. Non stripped libraries are notoriously hard to build in a reproducible way, so I'm fixing this by simply stripping the test libraries before comparing them on the affected platforms.

On Linux, only the gtest version of libjvm.so needs to be stripped. On Solaris and macosx, all libraries and executables need it. By stripping them, we no longer need to skip the simple binary diff check.

I have run the baseline compare builds at least 3 times on each platform with this change without seeing failures.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224145

Webrev: http://cr.openjdk.java.net/~erikj/8224145/webrev.01/index.html

/Erik

Reply via email to