We could add a check for the existing OS_VERSION_MAJOR variable , this
shows the kernel version but from my understanding the kernel to OSX mapping
is pretty stable
e.g. something like :
diff -r 7cf925f385fe make/autoconf/toolchain.m4
--- a/make/autoconf/toolchain.m4 Wed Jun 19 08:43:23 2019 +0200
+++ b/make/autoconf/toolchain.m4 Wed Jun 19 13:28:37 2019 +0200
@@ -224,6 +224,11 @@
VALID_TOOLCHAINS=${!toolchain_var_name}
if test "x$OPENJDK_TARGET_OS" = xmacosx; then
+ # check for min. OSX 10.12 (kernel version 16.X from uname)
+ if test $OS_VERSION_MAJOR -lt 16; then
+ AC_MSG_ERROR([OSX version 10.12 / kernel version 16 or higher is
required])
+ fi
+
if test -n "$XCODEBUILD"; then
# On Mac OS X, default toolchain to clang after Xcode 5
XCODE_VERSION_OUTPUT=`"$XCODEBUILD" -version 2>&1 | $HEAD -n 1`
( or use the sw_vers command and check the output
sw_vers -productVersion
10.12.6
)
What do you think ?
Best regards, Matthias
From: Baesken, Matthias
Sent: Mittwoch, 19. Juni 2019 09:51
To: 'build-dev@openjdk.java.net' <build-dev@openjdk.java.net>
Cc: Schuenemann, Rene <rene.schuenem...@sap.com>
Subject: jdk/jdk (+jdk12) Build failure on OSX 10.11
Hello, I noticed that we fail on OSX 10.11 in the build . Reason is that
NSWindowStyleMaskDocModalWindow is used since :
https://hg.openjdk.java.net/jdk/jdk/rev/6daafebf8189
8208543: [macos] Support for apple.awt.documentModalSheet incomplete
Which is 10.12+ functionality . See
https://developer.apple.com/documentation/appkit/nswindowstylemask/nswindowstylemaskdocmodalwindow?language=objc
NSWindowStyleMaskDocModalWindow
The window is a document-modal panel (or a subclass of
NSPanel<https://developer.apple.com/documentation/appkit/nspanel?language=objc>).
macOS 10.12+
I would prefer to test for minimum 10.12 already in configure , what do
you think ?
Best regards, Matthias
