It's trivial IMHO. Ship it. On Thu, Jul 4, 2019, 09:30 Baesken, Matthias <[email protected]> wrote:
> Hello, any more reviews ? > > May I push the change ? > > > > Best regards, Matthias > > > > > > > > *From:* Thomas Stüfe <[email protected]> > *Sent:* Mittwoch, 3. Juli 2019 14:09 > *To:* Baesken, Matthias <[email protected]> > *Cc:* [email protected]; [email protected] > *Subject:* Re: RFR: [XS] 8227171: provide function names in native stack > trace on aix with xlc16 > > > > Looks good and trivial. Thanks for fixing. > > > > ..Thomas > > > > On Wed, Jul 3, 2019 at 2:02 PM Baesken, Matthias <[email protected]> > wrote: > > Hello please review this small fix for AIX (needed with the new xlc16) . > > Currently we miss function names in the hs_err file : > > 0x0000000115098660 - 0x090000000f629a4c libjvm.so::<nameless > function>+0x6c (C++ saves_lr stores_bc gpr_saved:4 ) > 0x00000001150986f0 - 0x09000000113594bc libjvm.so::<nameless > function>+0x95c (C++ saves_lr stores_bc gpr_saved:18 ) > > The output contains "nameless function" instead of the (member) function > names . > Looks like this unwanted behavior was introduced when switching to the > xlc16 compiler. > > With xlc16, it looks like we have to configure the traceback table > generation to get the output we need. > > The -qtbtable=full setting can be used for this _ > > > https://www.ibm.com/support/knowledgecenter/SSGH4D_16.1.0/com.ibm.xlf161.aix.doc/compiler_ref/tbtable.html > > > > Bug / webrev : > > https://bugs.openjdk.java.net/browse/JDK-8227171 > > http://cr.openjdk.java.net/~mbaesken/webrevs/8227171.0/ > > > Thanks, Matthias > >
