+1 Thanks, Martin
> -----Original Message----- > From: build-dev <build-dev-boun...@openjdk.java.net> On Behalf Of > Langer, Christoph > Sent: Montag, 8. Juli 2019 15:26 > To: Baesken, Matthias <matthias.baes...@sap.com>; Thomas Stüfe > <thomas.stu...@gmail.com> > Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net > Subject: [CAUTION] RE: 8227389: Remove unsupported xlc16 compile options > on aix - was : RE: AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is > not > supported > > Hi Matthias, > > looks good! > > Best regards > Christoph > > > -----Original Message----- > > From: build-dev <build-dev-boun...@openjdk.java.net> On Behalf Of > > Baesken, Matthias > > Sent: Montag, 8. Juli 2019 14:00 > > To: Thomas Stüfe <thomas.stu...@gmail.com> > > Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net > > Subject: [CAUTION] 8227389: Remove unsupported xlc16 compile options > on > > aix - was : RE: AIX xlc16 options langlvl=c99vla / langlvl=noredefmac is not > > supported > > > > Hello, here is a small webrev removing the 2 mentioned options . > > > > When compiling jdk/jdk on AIX (using current xlc16 / xlclang) we run into > > these warnings : > > > > warning: 1540-5200 The option "langlvl=c99vla" is not supported. : > > This option controls variable length arrays / Enables or disables support > > for > > C99-type variable length arrays. > > warning: 1540-5200 The option "langlvl=noredefmac" is not supported. : > > Controls whether a macro can be redefined without a prior #undef or > > undefine() statement. > > > > see > > > https://www.ibm.com/support/knowledgecenter/SSGH3R_16.1.0/com.ibm. > > compilers.aix.doc/compiler.pdf > > > > > > The mentioned options are only available with the legacy xlc (non xlclang). > > I propose to remove these options, because xlc16 / xlclang is now the > default > > compiler. > > > > > > Bug/webrev : > > > > https://bugs.openjdk.java.net/browse/JDK-8227389 > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8227389.0/ > > > > > > > > Thanks and best regards, Matthias > > > > > > > > I think this is fine for 14. > > > > Cheers, Thomas > > > > On Mon, Jul 8, 2019 at 9:23 AM Baesken, Matthias > > <matthias.baes...@sap.com<mailto:matthias.baes...@sap.com>> > wrote: > > Hello, when building jdk/jdk on AIX (using the current default xlc16) > > I > get > > a ton of warnings : > > > > warning: 1540-5200 The option "langlvl=c99vla" is not supported. > > warning: 1540-5200 The option "langlvl=noredefmac" is not supported. > > > > > > The 2 options seem to be gone with the current xlc16 / xlclang++ . I > would > > like to remove them - any objections ? > > (removing them might be bad for older xlc versions but I think we > probably > > cannot compile with older versions any more ) . > > > > > > Best regards, Matthias