Hi Christoph,

On Thu, 2019-10-10 at 12:16 +0000, Langer, Christoph wrote:
> Hi,
> 
> please help reviewing this backport of a build infrastructure change to 
> jdk11u.
> 
> One reason for doing this is parity with Oracle's 11.0.6 but the patch also 
> contains some test improvements which will help stabilizing 11u testing. This 
> mainly means increasing some test timeouts for a few tests that tend to 
> timeout on slow or busy test hardware.
> 
> The patch mostly applies, apart from these two rejects:
> make/RunTests.gmk: 
> http://cr.openjdk.java.net/~clanger/webrevs/8212028.11u-dev.0/8212028-RunTests.gmk.rej
> make/RunTestsPrebuilt.gmk: 
> http://cr.openjdk.java.net/~clanger/webrevs/8212028.11u-dev.0/8212028-RunTestsPrebuilt.gmk.rej
> So, when reviewing, please have the most thorough look at these places.
> 
> I ran the fix through our nightly tests and didn't find regressions. I'm 
> planning to push backport JDK-8213005 together with this change, as it fixes 
> a regression for it.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212028
> Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/28375a1de254
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8212028.11u-dev.0/

 222 langtools_JTREG_MAX_MEM := 768m
 223 
 224 langtools_JTREG_MAX_MEM := 768m

Lines 222 and 224 in RunTests.gmk are duplicates.

Otherwise seems fine.

Thanks,
Severin

Reply via email to