Looks good.
/Erik
On 2019-10-15 03:19, Magnus Ihse Bursie wrote:
The ExecuteWithLog macro in make/MakeBase.gmk has logic to handle the
case where the command to run returns an error. Part of the error
handling is copying the resulting log file to the failure-logs
directory. However, that directory may not exist, so the copy may fail.
Also, in the LogCmdlines call at the start of the macro "Executing" is
misspelled.
Bug: https://bugs.openjdk.java.net/browse/JDK-8223998
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8223998-missing-makedir-in-executewithlog/webrev.01
/Magnus
