Thanks Phil!
Yasumasa
On 2019/11/19 11:43, Philip Race wrote:
OK
-phil.
On 11/18/19, 5:34 PM, Yasumasa Suenaga wrote:
PING: Could you review it?
JBS: https://bugs.openjdk.java.net/browse/JDK-8220074
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.01/
I think it is a trivial change.
Yasumasa
On 2019/11/13 11:42, Yasumasa Suenaga wrote:
Thanks Erik!
I uploaded new webrev, and it passed all tests on submit repo
(mach5-one-ysuenaga-JDK-8220074-1-20191113-0112-6660052).
http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.01/
Yasumasa
On 2019/11/13 3:04, Erik Joelsson wrote:
Hello,
There is no need to do compiler version checks like this. We just add all the
necessary warning disabling for all versions. GCC will not fail or warn for
invalid -W-no... flags and we use this feature for this very reason. We don't
think it's feasible to track warnings per compiler versions..
/Erik
On 2019-11-12 06:48, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8220074
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.00/
I saw some -Wstringop-truncation warnings in LCMS when I build OpenJDK with GCC
9.2.1 on Fedora 31.
They are LCMS problems, thus we should avoid them to disable these warnings.
This change has been tested on submit repo
(mach5-one-ysuenaga-JDK-8220074-20191112-1334-6642576).
Thanks,
Yasumasa
