Erik/Tim, thanks for the reviews!

On more small change: Update building.md (and .html) to reflect the deprecation 
of the ports:

http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open/webrev/ 
<http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open/webrev/>

Let me know if you think of other places where this should be reflected.

Cheers,
Mikael

> On Nov 22, 2019, at 6:17 AM, Tim Bell <tim.b...@oracle.com> wrote:
> 
> Mikael:
> 
> Looks good to me as well.
> 
> Tim
> 
> On 2019-11-22 06:10, Erik Joelsson wrote:
>> Looks good.
>> /Erik
>> On 2019-11-20 12:03, Mikael Vidstedt wrote:
>>> 
>>> I noticed that most of the configure options include the default value in 
>>> the help string (in brackets), so here’s an updated webrev which does 
>>> exactly that:
>>> 
>>> Webrev: 
>>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/webrev
>>> Webrev (incremental): 
>>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open/webrev/
>>>  
>>> 
>>> Cheers,
>>> Mikael
>>> 
>>>> On Nov 20, 2019, at 7:47 AM, Erik Joelsson <erik.joels...@oracle.com 
>>>> <mailto:erik.joels...@oracle.com>> wrote:
>>>> 
>>>> Looks good.
>>>> 
>>>> /Erik
>>>> 
>>>> On 2019-11-18 15:28, Mikael Vidstedt wrote:
>>>>> Please review this change which implements the changes for JEP 362: 
>>>>> Deprecate the Solaris and SPARC Ports.
>>>>> 
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
>>>>> Webrev: 
>>>>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/webrev/ 
>>>>> 
>>>>> I’ve tested that the expected error message is produced by default, and 
>>>>> that running with --enable-deprecated-ports=yes produces a warning 
>>>>> instead.
>>>>> 
>>>>> Cheers,
>>>>> Mikael
>>>>> 
>>> 
> 

Reply via email to