HiPengfei,
On 29/11/2019 10:01, Pengfei Li (Arm Technology China) wrote:
>> Can you explain why you have modified sharedRuntime_aarch64.cpp to
>> include nativeInst_aarch64.hpp? I don't see any other change in the source
>> file that would make this necessary.
>
> Thanks for review. There is another build error below after I fixed
> arguments.cpp.
>
> For target hotspot_variant-client_libjvm_objs_sharedRuntime_aarch64.o:
> ....../src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:2836:22: error:
> 'NativeInstruction' has not been declared
> __ add(r20, r20, NativeInstruction::instruction_size);
>
> We see that sharedRuntime_aarch64.cpp uses NativeInstruction but doesn't
> include nativeInst_aarch64.hpp.
> There is no error in Server VM build because the header file is included
> indirectly from some C2 file.
> But for Client VM build where C2 files are not in, this error occurs.
Ok, in that case the patch is good to push.
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill
