I’m not actually sure, but just to be on the safe side I’d prefer to add the grouping.
Cheers, Mikael > On Dec 16, 2019, at 11:45 AM, John Paul Adrian Glaubitz > <glaub...@physik.fu-berlin.de> wrote: > > On 12/16/19 8:40 PM, John Paul Adrian Glaubitz wrote: >> Hi Mikael! >> >> On 12/16/19 8:38 PM, Mikael Vidstedt wrote: >>> You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. >>> The suggested change will incorrectly *not* produce a warning for >>> solaris/*/zero. >>> >>> Something like this should do the trick: >>> >>> if test "x$OPENJDK_TARGET_OS" = xsolaris || (test >>> "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && test "x$with_jvm_variants" != >>> xzero); then >> >> >> Thanks for the review. As far as I remember correctly, Zero is not >> supported, is it? > "Zero is not supported on Solaris", I meant. Sorry. > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer - glaub...@debian.org <mailto:glaub...@debian.org> > `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de > <mailto:glaub...@physik.fu-berlin.de> > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
