Hi Erik, yes true sorry for answering your comments a bit late . > If a user runs jlink and includes all the jmods we ship with the JDK, the > result > should be essentially equivalent to the original JDK image. The way the > stripped pdb files are included in the bundles sort of at the last > second of the build here breaks this property.
I think we should address this in a separate bug/CR . Looking for example into a Linux build, I see a lot of debuginfo files in the jdk image (more or less for every shared lib) . But when looking into the jmods of that jdk image , no debuginfo files are in there ( I checked the java.base jmod). So putting the files with debug information into the jmods seems to be something that was not done so far cross platform (or is there some build switch for it that I did not check?) . Maybe to keep the jmods as small as possible . > To properly implement this, care will need to be taken to juggle the two > sets of pdb files around, making sure each build and test use case has > the correct one in place where and when it's needed. Quite possibly, we > cannot cover all use cases with one build configuration. Developers > needing the full debug symbols when debugging locally would likely need > to disable the stripped symbols so they get the full symbols everywhere. > Possibly this would need to be the default for debug builds and > configurable for release builds. From my limited experience , the developers do not work with the bundles (that would contain now after my patch the stripped pds) but with a "normal" jdk image that is created my make all. Best regards, Matthias > > This still does not address anything in my objection. > > /Erik > > On 2020-01-22 07:46, Baesken, Matthias wrote: > > Hello, here is an updated version : > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8237192.3/ > > > > this one supports a configure switch "--enable-stripped-pdbs" to enable > the feature . > > > > Best regards, Matthias > > > > > >> -----Original Message----- > >> From: Baesken, Matthias > >> Sent: Dienstag, 21. Januar 2020 11:03 > >> To: 'David Holmes' <david.hol...@oracle.com>; 'build- > >> d...@openjdk.java.net' <build-dev@openjdk.java.net>; 'hotspot- > >> d...@openjdk.java.net' <hotspot-...@openjdk.java.net> > >> Subject: RE: RFR: 8237192: Generate stripped/public pdbs on Windows for > >> jdk images > >> > >> > >> Hi David , yes I think it makes sense to have a configure option for this > >> . > >> Not everyone would like to have a larger JDK (even it is only a bit > >> larger). > >>
