Hi Magnus , putting those files into OPT_SPEED_SRC means using -O3 on them, while the other cpp files are built with -Os ( the list comes only into play when the jvm-feature "minimal" was been configured , see the ifeq ($(call check-jvm-feature, minimal), true) ).
But we built those files in the normal/regular productive make already with -O3, and this works fine so I would not see any issues here ... Best regards , Matthias > > On 2020-02-05 10:49, Baesken, Matthias wrote: > > Hello, please review this small change . > > > > The OPT_SPEED_SRC list (for files to be built optimized for speed) in > JVMFeatures.gmk includes a few files with cpu-dependend names for arm > > but misses the corresponding files for other cpus (e.g. frame_arm.cpp). > The change adds those files . > > > > Bug/webrev : > > > > https://bugs.openjdk.java.net/browse/JDK-8238530 > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8238530.0/ > (cc:ing our resident optimization expert Claes) > > As usual, Oracle does not care much about ppc, s390 and aarch64. You can > optimize them however you want. :) > > But you have also added frame_x86.cpp and icache_x86.cpp. How does this > affect performance and correctness on the x64 platform? I'd like you to > either answer that question, or remove the x86 files from this patch. > Changes in optimization in frame files sounds like scary stuff without > proper verification. > > /Magnus > > > > Best Regards, Matthias > >
