Looks good to me, Magnus!

/Claes

On 2020-02-21 09:44, Magnus Ihse Bursie wrote:
Running gtest on Solaris broke with JDK-8239450, with a message like:

ld.so.1: gtestLauncher: fatal: libstlport.so.1: open failed: No such file or directory

This breaks our CI builds.

The problem is that the code checking for the presence of libstlport.so.1 only tried to do so if gtest was enabled, but the check for gtest was moved to after the library setup. Apparently, the tests I ran for JDK-8239450 did not include running gtest on Solaris. :-(

Bug: https://bugs.openjdk.java.net/browse/JDK-8239566
WebRev: http://cr.openjdk.java.net/~ihse/JDK-8239566-fix-gtest-solaris/webrev.01

/Magnus

Reply via email to